2025 public meeting minutes

2025 public meeting minutes

Meetings connection details

available at TransportPCE meetings
https://lf-opendaylight.atlassian.net/wiki/display/ODL/TransportPCE+meetings

 

2025-03-27

General information

  • Sc-SR2 has been officially released this week. TransportPce and BGPCEP are incompatible features and can’t be activated simultaneously.

  • Ti was originally planned last week. It will be delayed. It will include OpenConfig PortMapping and maybe OpenConfig Renderer. Ti will also include MC-capabilities change suite.

Code Review

Changes merged during the week:

  • nothing

Changes under review on master branch:

  • “Refresh spectrum info at service creation” & “Refresh AvailablePayloadStructure @ service create” are ready to be merged.

  • 2 changes from the LFN enabling CI features are ready to be merged.

  • Roshan has planned to push some changes to address our comments by the end of this week. He will also push the functional tests in the coming week.

  • Olivier updated his relation chain on TAPI -PCE to keep separate tests from code consolidation.

2025-03-20

General information

  • Status of Sc-SR2 release: ODL distribution is still pending.

  • Status on MC-capabilities bug:

    • Joakim is trying to create a ROADM 7.1 configuration to test his code. He started from ROADMA example available on tpce repo, but this is probably not the one to use. 7.1 configuration on the repo are very simple configuration translated from 2.2.1. The most reliable configuration we have until now is the ROADMD configuration proposed by Bala in his latest change.

    • Having some samples of the configuration of the ROADM (2.2.1 and 7.1) would be helpful. More specifically the mc-capabilities of the SRG and Degrees of ROADM and notably the max-slot parameters. It has been provided in Aparaajitha’s mail.

Code Review

Changes merged during the week:

  • “Allow project build for user settings”, “MC-capability improved error message”

Changes under review on master branch:

  • “Support for OpenConfig Renderer”, pushed by Fujitsu has been reviewed by Gilles last week and Olivier this week.

  • “Initial TAPI 2.4  PVE OTN Node Class” is a new change that introduces the code to handle abstracted Tapi OTN node in the PCE

2025-03-13

General information

  • Status of Sc-SR2 release: All projects (TPCE included) released again artifacts for Sc-SR2. BGPCEP issues have been solved.

  • Ti deadline was fixed to next week. It will probably suffer of several weeks of delay.

  • TPCE forecast content for Ti: main features will be:

    • Handling of OpenConfig devices (PortMapping, Topology and also probably Rendering function),

    • and Managing of different frequency granularities through heterogeneous ROADM network

  • TPCE Vanadium forecast content:  

    • Gilles would like to cancel the support of openroadm devices in the all first 1.2.1 version which brings some issues as it is really different from others, and OpenROADM-version enums does not exist for 1.2.1. As we may support some new release of OR devices (AT&T is considering version 13.1.1) this will also simplify the introduction of the support for new models.

    • Support of Service and Network Model 17.0 to have mc-capabilities so that we can avoid any dependency to portMapping in the PCE module.

Code Review

Changes merged during the week:

On stable/scandium branch:

  • Changes associated with Project version and upstream dependencies bumps.

On master branch:

  • All the Joakim's releation chain that bring a new interesting feature which is the ability to manage flex grid networks when ROADM devices may have heterogeneous flex grid capabilities

  • Bump of upstream dependencies to the latest Sc-SR2 release versions in order to not have the master branch behind the scandium branch

Changes under review on master branch:

  • “Support for OpenConfig Renderer”, pushed by Fujitsu has been reviewed by Gilles. Next step concerns functional tests that will be pushed at the end of next week by Fujitsu. The lightynode will be updated in the next step by Orange.

  • “Allow project build for user settings”: this change is to provide own settings as some proxy do not allow to use the odl-setting files.

  • “Update hybrid functional tests to use 7.1 ROADM”: Gilles provided some feedback. Gilles suggests just updating ROADM-C with a 7.1 config files.

  • IPoWDM relation chain: Gilles rebased the code making some corrections so that it passes the gate.

  • Joakim pushed a new relation-chain : “Introduce env variable controlling timeout” was reviewed by Gilles, and comment were addressed. “Replace post interface infinite loop with timeout” and “Replace static timeout variable with config class” are WIP and will be better addressed in next meeting.

  • “Tapi avoid NPE reading supportive service” corrects a bug and is ready to be merged.

Other

  • Gilles suggest that we modify enums of OpenROADM versions, so that all of them are coded as “x.x.x”. This would allow avoiding some issue with the way the enum are coded by yangtools in ODL, which provides the same value for 1.2.1 and 12.1. Bala mentions that this would be difficult to make it prior to R17.1, since everything has already been fixed for R17.0.

2025-03-06

General information

  • Status of ScSR2 release: All core project were released again to have a new distribution. Unfortunately, we still have a major regression in BGPCEP. So Sc-SR2 may be re-released once again.

Code Review

Changes merged during the week:

On master branch:

  • “Complement converters test with TAPI dataObject” and changes related to Sc-SR2 (“Bump upstream dependencies”, “Bump project version to 10.2.2-SNAPSHOT”).

 Changes under review on master branch:

  • Relation chain of Joakim is almost ready to be merge.

    • For change “Implement mc min/max slots in portmapping”, Olivier suggests that we add a security in the code, to avoid setting something that results in not being able to support a signal with a bandwidth that is 37.5 GHz (the minimum MC width specified by OR). This could happen in the case MaxSlot number has not been set by the device, whereas the slotWidth and CenterFrequency granularities have been set to a value that is lower than 50 GHz.  

    • “Service Spectrum assignment uses MC-Capabilities” : Gilles proposes to keep it as is. He just mentioned that he would recommend to limit the use of external libraries that are not already used in transportPCE , such as xstream library used in this change, in order to simplify the migrations when required by OpenDaylight project life, as deprecation of libraries is always a pain to manage. He considers that a refactoring of PceOpticalNode could be done later so that we would be able to create the Graph used in PCE Junit tests by programm and thus remove this library.

  • “Support for OpenConfig Renderer” has been recently pushed by Fujitsu and will require some review. The lightynode shall however be updated to be able to build functional tests, with simulators able to mimic equipment behavior, and creating the right interface as soon as they are rendered by transportPCE.

2025-02-27

General information

  • Status of ScSR2 release: TransportPCE and BGCEP will be made as exclusive features meaning they can’t be activated at the same time. This is to solve the issue addressed during last meeting (incompatibility between some OpenConfig models used with different revisions in the two projects). Anyway, Other regressions were observed and Robert had to respin an updated release on upstream projects for the Sc-SR2 release.
    Gilles released again transportpce-models yesterday. Now waiting for availability of netconf-8.0.6 to finish.

Code Review

Changes merged during the week:

On master branch:

  • All Gilles’s relation chain: a number of code improvements that were already discussed last week have been merge, as well as relation chain associated with additional clean-up. All these changes have been backported to the stable/scandium branch to be part of the Sc-SR2 release.

 Changes under review on master branch:

  • Olivier’s changes on TAPI development:

    • “Refresh spectrum info at service creation” could be merge, after the commit message has been reformatted.

    • “Refresh Available payloadStructure @ service creation”, does not pass the gate due to pylint issues.

  • Christophe change on TAPI topology handling for TAPI-SBI:

    • “Complement converters tests with dataObject”: this change is paving the way to get TAPI SBI. All comments have been addressed and the change is ready to be merge.

  • Joakim’s Relation chain has been reviewed by Gilles and Olivier who made comments.

  • “Bump upstream dependencies” is for migration to Sc-SR2 which Gilles prepared, but is not ready for merge yet.

2025-02-20

General information

  • Gilles is currently releasing transportPCE for Sc-SR2. An incompatibility issue between different versions of same OpenConfig models used in transportPCE and BGPCEP projects has just been detected at the final distribution integration step. Gilles and Robert see how to remedy this in the most appropriate way. A bug has been reported in the yangtools project.

  • The LFN announced plans to migrate from Slack to Zulip.

Code Review

Changes merged during the week:

On master branch:

  • All Gilles’s relation chain aiming at improving tpce code: “Use Java.nio to manage file”, “Use availability in JUnit tests requiring timeout”, Generalize static imports for Mockito/assertions”, “Generalize the use of Junit5 assertions”, Generalize use of Uint constant when available”, “Generalize use of StandardCharsets constants”, “Migrate last remaining uses of InstanceIdentifier”,

  • Part of Olivier’s relation chain on TAPI developments: “Refactor tapi topo Convert XXX classes” , “Correct bugs in Tapi Conversion factory” and  “Correct CEP management at service creation”.

  • Changes related to the migration of dependencies to Sc-SR2

  • All these changes have been backported to stable/scandium branch to be part of Sc-SR2 release.

 Changes under review on master branch:

  • The LFN pushed 2 changes to enable Github to Gerrit pass flow.

  • Joakim Relation chain has been revised. Joakim has added an environment variable that allows to set the behavior of the controller to define the way the spectrum is filled in “Implement center-freq-granularity in freq. select”.

  • “Complement converters tests with Tapi dataObject” has been pushed by Christophe but does not pass the gate. It is related with the development of the TAPI SBI.

  • Gilles pushed a new relation chain to remove some compilation warnings including “Clean up maven dependency declarations”, “Add missing type argument for generic class”, “Migrate registration of some RPC implementations”, “Fix javadoc compilation warnings”, “Add mising serialVersionUID”, “Refactor RPC registration in TapiNetworkUtilsImpl” which refactors the code to simplify rpc registration, “fix some this-escape compilation warnings” and “Clean up the code across the entire project” which remove useless declaration in exception throwing.

2025-02-13

General information

  • Sc SR2 shall be released soon

Code Review

Changes merged during the week:

On master branch:

  • “Correct Bugs at tapi uninstall” has been merged.

  • “Migrate usage of hacrest Junit test library to AssertJ”: includes the rationalization of Junit tests.

On stable/scandium branch:

  • Around thirty changes merged on master branch since January have been backported to stable/scandium branch in order to prepare the Sc-SR2 release. Only the changes related to handling an OpenConfig node in TPCE have not been backported since considered as a new feature taht will be introduced in Titanium (planned for March)

 Changes under review on master branch:

  • Gilles’s releation chain:

    • “Use Java.nio to manage file”: address Junit tests and replaces old java.io library by the more modern java.nio one.

    • “Remove useless call to toIdendentifier methode”: In the TPCE code, unnecessary calls to the toIdentifier() method were hanging around since migrating InstanceIdentifiers objects to DataObjectIdentifier. This change is deleting them to make things cleaner.

    • “Remove some dead code lying araound”: some commented code resulting from a rebase were still present in the code…

    • “Use sft.skip in TPCE features pom files”: solves some maven compilation warnings.

    • “Bump upstream dependencies to Sc SR2”: this is a pending change since the Netconf depenency is not the targeted one.

    • “Fix Javadoc checkstyle issues” allows addressing enforced rules on Sc SR2

  • Relation chain from Joakim: adds additional support for MC capabilities min and max slot count for degrees and srgs.

    • “New package for center frequency granularity LCM” allows to find a granularity that is adapted to a mix of SRGs in ROADM architecture.

    • “New package aiding finding available frequencies”: related to the fact that frequency granularity could be defined when having a mix of SRGs. It concerns anchor frequency and the way to define slots in conformance to the frequency granularity that is defined.

    • “Implement center frequency granularity in freq. select”: this change is bringing some strong modifications in the way we fill the spectrum. Olivier considers that spectrum filling is really a thing that operators want to manage according to their own rules. Thus he would prefer that if SmartOptics wants to change the way the spectrum is filled, they work on a way to improve the controller customization module and then develop the code to implement the new rules that are defined in this model. Potential complements to that module could define the way the spectrum shall be filled (from the lowest wavelength to the highest or reversely).

    • “Service spectrum assignment uses MC-capabilities”: this change through Service spectrum assignment, uses slot width granularity and min/max-slots to determine if a degree/srg is compatible with the required service frequency slot width.

    • “Spectrum assignment fixgrid only for 1.2.1” simplifies spectrum management in the case of a fix-grid.

  • Relation chain to improve tapi topology management

    • “Refactor tapi topo Convert XXX classes” is ready to be merged

    • “Correct bugs in Tapi Conversion factory” adds the management of layer-protocol qualifiers and corrects some frequency multipliers

    • “Correct CEP management at service creation” adds the creation of eODU Cep on client ports connected to a network port, when the port is activated through a photonic service creation. It also improves scalability handling connection and their underlying elements. It adds the creation of I_OTU connections.

    • “Refresh Spectrum info at service creation” allows updating the spectrum (available/occupied) after a wavelength has been provisonned.

    • “Refresh AvailablePayloadStructure @ service create” in still in progress. It updates the payload structure when creating DSR and ODU services.

2025-02-06

Code Review

Changes merged during the week:

  • Relation chain including the use of binding map, the refactoring to centralize constants in common module, and some remaining work on DataObject Identifier.

  • The second part of the relation chain which concerns serializer and deserializer that have been reworked from the code of test-common. This also includes the removal of Json Util class from the converters.

  • “Fix ROADM provisioning for 7.1 models” has been merged. Bala is working on providing the related functional tests.

  • Roshan’s change “Changes to update nbl and add rate in PortMapping” which brings some corrections to the OpenConfig PortMapping.

Changes transportpce under review on master branch:

  • “Refactor tapi topo ConvertXXX classes”: Gilles proposes a common review of this change to potentially redefine the class names.

  • “Correct bugs at tapi uninstall” could be merged.

  • “Correct CEP management at service creation” shall be set as WIP as another patchset correcting the spectrum use is expected either amending this one, or on top of it.

  • “Correct bugs at tapi uninstall”: some rebase message that was commented needs to be cleaned up, and then the change can be merged.

  • Smartoptics has pushed a new relation chain. These changes are linked with frequency granularities handling. As we understand it may be associated with some use cases where different kinds of SRG could cohabit with different constraints on frequency granularities

Other

  • UTD mentioned during the discussion the fact that they have been working on Routing and Wavelength assignment and may make some proposal at a time to improve the way we allocate wavelengths.

2025-01-30

Code Review

Changes merged during the week:

  • “Add openconfig node in openroadm network layers” includes the refactoring  of NetworkModelServiceImpl to add and remove openconfig nodes in openroadm network layers (clli, network, topology, otn)

  • “Replace use of deprecated methods in tapi module”.

  • Tapi relation chain of Olivier has been merged.

  • “ New observer package subscribing for error ms”: provides a way of collecting error messages for later use. The class contains methods extracting the first or last message from a given type (error, warning etc). It is useful in the case of an iteration where it's not uncommon for errors to occur during the iteration, although at some point in the iteration at least one item should complete without error.

  • “ Implement error message subscriber”: adds a more descriptive error message for the create service API, providing more context in case the process fails.

  • “New result message builder (WeightedResultMessage)” :  simplifies the creation of result.

Changes transportpce under review on master branch:

  • Bala’s change “Fix ROADM provisioning for 7.1 models” has been reviewed and can be merged.

  • “Correct bugs at tapi uninstall ” is also ready to be merged.

  • “Implement new converters in test-common”: This change allows using more simple converters to serialize/deserialize DataObject to/from String for Junit test purpose.

  • “Remove JsonUtils from test-common”: was proposed as some code became redundant with the code for the new JsonDataConverter JsonUtils which is then no longer used.

  • “Refactor tapi topo ConvertXXX Classes” proposes a refactoring of the Classes used to convert OR to TAPI topology. This is mainly done changing name of classes to a more comprehensive name, and adding java docs. It also Integrates modifications proposed in change #114944 that can be back- ported respecting expected behavior at the target.

  • “Correct bugs in tapi conversion Factor” is correcting a few bugs in creating Tapi Topology form OR topo in Data-store. It is ready to be merged.

  • “Refactor some uses of Map” uses, when possible, utility means that makes Map handling easier.

  • “Move constants from NetworkUtils in common module”: NetworkUtils class specifies few constants which are used almost everywhere. Move them on the StringConstants class of common module which is dedicated to centralize all constants. Also rename a few of them to make them more explicit.

  • “Refactor some DataObjectIdentifier” : proposes to use some WithKey and  remove one usage of a deprecated InstanceIdentifier method.

  • Joakim pushed a new package dedicated to handle in a better way center frequency granularity. This requires further review.

Other

  • Question from UTD in the scope of OFC2025 preparation: In K branch, when a Request for a temp service was exercised, the port selected by transportPCE was the first one. UTD would like to know if this has been solved in Sc. Answer: we still have the issue in some cases. NW service from PP to PP works. But when we have several Xponder ports we still have the issue. To solve it, we would need to change the library used for path computation. We may leverage constraints to find some workaround. Some Junit tests have been developed around this.

2025-01-23

General information

  • Today should have been the release of Sc-SR2, but it will be delayed.

Code Review

Changes merged during the week:

  • The Relation chain of Gilles including the migration from Instanceidentifier to DataObjectIdentifier object, “Clean up the pom files”, “Remove NodeData class which is never used”, and “Add missing javadoc in networkmodel module” has been merged. It removes lots of compilation warnings.

  • “Fix NPE in OCPortmapping” and “Move openconfig functional test library to common”.

  • “Load openroadm Operational mode catalog at init”

  • “Remove unused properties from PCE test classes”

  • “Move json utils to test common

Changes transportpce under review on master branch:

  • “Add openconfig node in openroadm network layers” is a new feature that allows populating the different layers of OpenROADM topology when the OpenConfig Portmapping is updated (for example at the connection to a new OC device). A new functional test suite has been created to check that when a new OpenConfig Nodes is connected, portmapping and topology are correctly updated. The change passes the gate and is ready to be merged.

  • “Refactor topology uuid in tapi module” proposed by Gilles has been reviewed by Olivier who suggests not to merge it, since in fact the proposal does not fit well with the evolution target (which was clearly not stated!). Olivier started working on a change to clarify what the tapi class do and what’s the target.

  • “Replace use of deprecated methods in tapi module”  needs now to be rebased.

  • “Add common-id to the path-computation-request” change from Bala has been commented by Jonas and and discussed at length in session

  • “Fix ROADM provisioning for 7.1 Models” needs to be rebased. Bala also needs to complement the associated functional tests.

  • Joakim pushed 3 new changes to manage error messages : “Implement error message subscriber” , “New result message builder (WeightedResultMessage)”, and “New observer package subscribing for error msg”.

Other

  • AT&T noticed that the PM collection fails with one equipment. The manufacturer answered that the PM list can take more than 15 minutes if no filter is applied. Bala did not see how we could apply any filters in tpce retrieving the PM list. No solution was identified during the meeting.

2025-01-16

Code Review

Changes transportpce under review on master branch:

  • The Relation chain of Gilles is still under review: it concerns the change from Instance identifiers to DataObjectIdentifier, Cleanup allowing to avoid a number of compilation Warning, removal of duplicated code, add of missing java-docs. Gilles is waiting for additional reviews before addressing comments.

  • “Fix NPE in OCPortmapping” brings protections to avoid raising NPE when we will face other/new OpenConfig Equipment.

  • “Load openroadm Operational mode catalog at init” allows to load the catalog at initialization for autonomous path computation. This was a missing part. Tests have been modified since fully enabling autonomous path computation impacts PCE behaviour.

  • “Move json utils to test common” rationalize the code and avoids duplications.

Other

  • OFC 2025 will be challenging, because a lot of companies will contribute to the same demos with not so well-defined expectations at that time.

2025-01-09

Code Review

Changes merged since the last meeting:

  • Relation chain solving the bug TRNSPRTPCE-837: Activating odl-transportpce-tapi disables openroadm featuresVerified : includes “activating odl-transportpce-tapi disables openroadm features”, “close properly the GnPy component”, “clean odl-transportpce feature”, “clean json stringConverter”, clean odl dmapp feature” and “Reimplement GNPy consumer without Jersey”.

  • Relation chain of Joakim handling service frequency which gives the ability to set a specific wavelength for a service.

  • “upgrade Lightynode version”: provides enhancement handling OpenConfig PortMapping

  • Change “Enhancements for discovering OpenConfig XPDRs“ from Roshan implementing the openconfig portmapping (for Titanium release)

Changes transportpce under review on master branch:

  • “Clean up the pom files”: Gilles provided this change that allows getting rid of a lot of compilation warnings.

  • “Migrate InstanceIdentifier of test-common/common/network-models …. modules”: All IID have been cleaned up so that they do not call deprecated objects. Remains few usages of InstanceIdentifier methods that are necessary and not present in DataObjectIdentifier/Reference objects.

  • “Remove Node Data class which is never used” to clean the code from dead code.

  • “Add missing javadoc in network module”: allows getting rid of lots of warning associated with Javadoc in networkmodel module.

  • “Fix NPE in OC portMapping”: Adds protection to avoid a NPE when the open-terminal-meta-data is not present,  reviewes some log level to improve log readability and optimizes the number of the datastore read access for the  meta-data.

  • “Load Openroadm-operational-modes catalog at init”: allows loading the operational mode catalog at initialization of transportpce.

  • “Remove unused properties from PCE test classes”: Some PCE test classes declare the BindingDOMCodecServices as a property but the latter is not used. Just delete it.

  • Olivier’s relation chain cleaning up the topology and allowing generating the topology files including correct NRGs and IRGs for both ROADMs and Xponders is ready to be reviewed/merged.

  • “Add common-id to the path-computation-request” is ready to be merged. This change corrects the fact that currently, the path computation request input is missing common-id parameter, which is must for temp-service.

  • Gilles started reviewing “Read optical-operational-mode in temp-service-create” and “Add OSNR calculations for IPoWDM use case”.

Other

Related content