/
2025 public meeting minutes

2025 public meeting minutes

Owned by Gilles THOUENON
Last updated: Jan 24, 2025
4 min read

Meetings connection details

available at TransportPCE meetings
https://lf-opendaylight.atlassian.net/wiki/display/ODL/TransportPCE+meetings

 

2025-01-23

General information

  • Today should have been the release of Sc-SR2, but it will be delayed.

Code Review

Changes merged during the week:

  • The Relation chain of Gilles including the migration from Instanceidentifier to DataObjectIdentifier object, “Clean up the pom files”, “Remove NodeData class which is never used”, and “Add missing javadoc in networkmodel module” has been merged. It removes lots of compilation warnings.

  • “Fix NPE in OCPortmapping” and “Move openconfig functional test library to common”.

  • “Load openroadm Operational mode catalog at init”

  • “Remove unused properties from PCE test classes”

  • “Move json utils to test common

Changes transportpce under review on master branch:

  • “Add openconfig node in openroadm network layers” is a new feature that allows populating the different layers of OpenROADM topology when the OpenConfig Portmapping is updated (for example at the connection to a new OC device). A new functional test suite has been created to check that when a new OpenConfig Nodes is connected, portmapping and topology are correctly updated. The change passes the gate and is ready to be merged.

  • “Refactor topology uuid in tapi module” proposed by Gilles has been reviewed by Olivier who suggests not to merge it, since in fact the proposal does not fit well with the evolution target (which was clearly not stated!). Olivier started working on a change to clarify what the tapi class do and what’s the target.

  • “Replace use of deprecated methods in tapi module”  needs now to be rebased.

  • “Add common-id to the path-computation-request” change from Bala has been commented by Jonas and and discussed at length in session

  • “Fix ROADM provisioning for 7.1 Models” needs to be rebased. Bala also needs to complement the associated functional tests.

  • Joakim pushed 3 new changes to manage error messages : “Implement error message subscriber” , “New result message builder (WeightedResultMessage)”, and “New observer package subscribing for error msg”.

Other

  • AT&T noticed that the PM collection fails with one equipment. The manufacturer answered that the PM list can take more than 15 minutes if no filter is applied. Bala did not see how we could apply any filters in tpce retrieving the PM list. No solution was identified during the meeting.

2025-01-16

Code Review

Changes transportpce under review on master branch:

  • The Relation chain of Gilles is still under review: it concerns the change from Instance identifiers to DataObjectIdentifier, Cleanup allowing to avoid a number of compilation Warning, removal of duplicated code, add of missing java-docs. Gilles is waiting for additional reviews before addressing comments.

  • “Fix NPE in OCPortmapping” brings protections to avoid raising NPE when we will face other/new OpenConfig Equipment.

  • “Load openroadm Operational mode catalog at init” allows to load the catalog at initialization for autonomous path computation. This was a missing part. Tests have been modified since fully enabling autonomous path computation impacts PCE behaviour.

  • “Move json utils to test common” rationalize the code and avoids duplications.

Other

  • OFC 2025 will be challenging, because a lot of companies will contribute to the same demos with not so well-defined expectations at that time.

2025-01-09

Code Review

Changes merged since the last meeting:

Changes transportpce under review on master branch:

  • “Clean up the pom files”: Gilles provided this change that allows getting rid of a lot of compilation warnings.

  • “Migrate InstanceIdentifier of test-common/common/network-models …. modules”: All IID have been cleaned up so that they do not call deprecated objects. Remains few usages of InstanceIdentifier methods that are necessary and not present in DataObjectIdentifier/Reference objects.

  • “Remove Node Data class which is never used” to clean the code from dead code.

  • “Add missing javadoc in network module”: allows getting rid of lots of warning associated with Javadoc in networkmodel module.

  • “Fix NPE in OC portMapping”: Adds protection to avoid a NPE when the open-terminal-meta-data is not present,  reviewes some log level to improve log readability and optimizes the number of the datastore read access for the  meta-data.

  • “Load Openroadm-operational-modes catalog at init”: allows loading the operational mode catalog at initialization of transportpce.

  • “Remove unused properties from PCE test classes”: Some PCE test classes declare the BindingDOMCodecServices as a property but the latter is not used. Just delete it.

  • Olivier’s relation chain cleaning up the topology and allowing generating the topology files including correct NRGs and IRGs for both ROADMs and Xponders is ready to be reviewed/merged.

  • “Add common-id to the path-computation-request” is ready to be merged. This change corrects the fact that currently, the path computation request input is missing common-id parameter, which is must for temp-service.

  • Gilles started reviewing “Read optical-operational-mode in temp-service-create” and “Add OSNR calculations for IPoWDM use case”.

Other