setmaxpath value range should be between 1 to 64 in BGP multipath
Description
Environment
Operating System: All
Platform: All
Activity
Jitendra Kumar November 2, 2017 at 6:49 AM
I have verified this with distribution: distribution-karaf-0.6.3-20171102.041639-88.zip
and it worked fine-
opendaylight-user@root>vpn-show
No Config VpnInterface is present
No Oper VpnInterface is present
-----------------------------------------------------------------------
VpnInstanceName RD Config Count Oper Count
-----------------------------------------------------------------------
12345678-1234-1234-1234-123456789300 [1:1] 0 0
-----------------------------------------------------------------------
Total Count: 0 0
Usage:To display vpn-interfaces for a particular vpnInstance vpn-show --detail [<vpnInstanceName>]
opendaylight-user@root>
opendaylight-user@root>multipath -r 1:1 -f lu -n 0 setmaxpath
error: --maxpath range[1 - 64]
opendaylight-user@root>multipath -r 1:1 -f lu -n 64 setmaxpath
opendaylight-user@root>multipath -r 1:1 -f lu -n 65 setmaxpath
error: --maxpath range[1 - 64]
opendaylight-user@root>
Gowri October 31, 2017 at 9:06 AM
Fix checked in - https://git.opendaylight.org/gerrit/#/c/64648
Former user September 28, 2017 at 8:33 AM
Added a check to ensure the maxpath value is between 1 and 64
Gerrit reviews:
https://git.opendaylight.org/gerrit/#/c/63434/
https://git.opendaylight.org/gerrit/#/c/63400/
https://git.opendaylight.org/gerrit/#/c/63433/
Details
Details
Assignee
Jitendra KumarReporter
Former userExternal issue ID
Priority (migrated 2)
Components
Affects versions
Priority
Medium
observation-
opendaylight-user@root>odl:multipath -f lu enable
opendaylight-user@root>multipath -r 1:1 -f lu -n 0 setmaxpath >>> this should throw error
opendaylight-user@root>bgp-cache
Configuration Server
Host 192.168.122.201
Port 7644
BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors
Multipath
Address-Families vpnv4
RD Maxpath
1:1 0 >>>>>>>>>>>>>>>>>> Allowed to configure which is not correct
opendaylight-user@root>odl:multipath -f lu enable
opendaylight-user@root>multipath -r 1:1 -f lu -n 65 setmaxpath >>>>>> setmaxpath configured as 65, which should not allowed
opendaylight-user@root>
opendaylight-user@root>bgp-cache
Configuration Server
Host 192.168.122.201
Port 7644
BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors
Multipath
Address-Families vpnv4
RD Maxpath
1:1 65 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
opendaylight-user@root>multipath -r 1:1 -f lu -n 100 setmaxpath >>>>>> setmaxpath configured as 100, which should not allowed
opendaylight-user@root>bgp-cache
Configuration Server
Host 192.168.122.201
Port 7644
BGP Router
AS-Number 200
Router-ID 20.20.20.20
Stale-Path-Time default
F-bit ON
Log-File /var/log/bgp_debug.log
Log-Level errors
Multipath
Address-Families vpnv4
RD Maxpath
1:1 100