RESTCONF 500 Error Not Properly Formatted
Description
Environment
split to
Activity
Ivan Hraško October 17, 2024 at 7:39 AM
https://git.opendaylight.org/gerrit/c/netconf/+/114022 needs manual cherry-picks.
Robert Varga October 16, 2024 at 11:01 AMEdited
For Netty we are handling an internal error, so we don’t know what went down and we handle it at HTTP (not RESTCONF) layer, hence we cannot really do the cutesy error-type/message header. Once the underlying NPE is fixed, we get:
Robert Varga October 16, 2024 at 10:44 AM
And the same thing happens with JAX-RS.
Robert Varga October 16, 2024 at 10:41 AM
The missing bit is this:
12:40:38.574 WARN [odl-restconf-nb-worker-0] Internal error while processing PendingOperationsPost{target=http://localhost:8182/restconf/operations/netconf-keystore:add-keystore-entry}
java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "obj" is null
at org.opendaylight.netconf.keystore.legacy.impl.SecurityHelper.decodePrivateKey(SecurityHelper.java:79) ~[?:?]
at org.opendaylight.netconf.keystore.legacy.impl.DefaultAddKeystoreEntry.invoke(DefaultAddKeystoreEntry.java:53) ~[?:?]
at org.opendaylight.netconf.keystore.legacy.impl.DefaultAddKeystoreEntry.invoke(DefaultAddKeystoreEntry.java:32) ~[?:?]
at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMRpcImplementationAdapter.invokeRpc(BindingDOMRpcImplementationAdapter.java:49) ~[?:?]
at org.opendaylight.mdsal.dom.broker.OperationInvocation.invokeGlobalRpc(OperationInvocation.java:101) ~[?:?]
at org.opendaylight.mdsal.dom.broker.OperationInvocation.invoke(OperationInvocation.java:53) ~[?:?]
at org.opendaylight.mdsal.dom.broker.DOMRpcRouter$RpcServiceFacade.invokeRpc(DOMRpcRouter.java:458) ~[?:?]
at org.opendaylight.mdsal.dom.spi.ForwardingDOMRpcService.invokeRpc(ForwardingDOMRpcService.java:29) ~[?:?]
at org.opendaylight.restconf.mdsal.spi.DOMServerRpcOperations.invokeRpc(DOMServerRpcOperations.java:47) ~[?:?]
at org.opendaylight.restconf.server.spi.InterceptingServerRpcOperations.invokeRpc(InterceptingServerRpcOperations.java:52) ~[?:?]
at org.opendaylight.restconf.server.spi.AbstractServerStrategy.operationsPOST(AbstractServerStrategy.java:368) ~[?:?]
at org.opendaylight.restconf.server.mdsal.MdsalRestconfServer.operationsPOST(MdsalRestconfServer.java:421) ~[?:?]
at org.opendaylight.restconf.server.PendingOperationsPost.execute(PendingOperationsPost.java:37) ~[?:?]
at org.opendaylight.restconf.server.PendingOperationsPost.execute(PendingOperationsPost.java:27) ~[?:?]
at org.opendaylight.restconf.server.PendingRequestWithBody.execute(PendingRequestWithBody.java:61) ~[?:?]
at org.opendaylight.restconf.server.AbstractPendingRequest.execute(AbstractPendingRequest.java:97) ~[?:?]
at org.opendaylight.netconf.transport.http.HTTPServerSession.executeRequest(HTTPServerSession.java:265) ~[?:?]
at org.opendaylight.netconf.transport.http.HTTPServerSession.channelRead0(HTTPServerSession.java:202) ~[?:?]
at org.opendaylight.netconf.transport.http.HTTPServerSession.channelRead0(HTTPServerSession.java:52) ~[?:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at org.opendaylight.netconf.transport.http.ServerSseHandler.channelRead(ServerSseHandler.java:121) ~[?:?]
at org.opendaylight.netconf.transport.http.ServerSseHandler.channelRead(ServerSseHandler.java:90) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at org.opendaylight.netconf.transport.http.AbstractBasicAuthHandler.channelRead0(AbstractBasicAuthHandler.java:56) ~[?:?]
at org.opendaylight.netconf.transport.http.AbstractBasicAuthHandler.channelRead0(AbstractBasicAuthHandler.java:35) ~[?:?]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93) ~[?:?]
at io.netty.handler.codec.http.HttpServerKeepAliveHandler.channelRead(HttpServerKeepAliveHandler.java:64) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:436) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) ~[?:?]
at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:251) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:266) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:537) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:469) ~[?:?]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[?:?]
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1357) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[?:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[?:?]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:868) ~[?:?]
at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:799) ~[?:?]
at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:501) ~[?:?]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:399) ~[?:?]
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[?:?]
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[?:?]
at java.lang.Thread.run(Thread.java:1583) [?:?]
When executing the RESTCONF operation to add a keystore entry via the following request:
The server responds with a 500 Internal Server Error:
Expected Behavior: The response should be a properly formatted error response as defined in the RESTCONF error handling standards.
Note: Error response for Internal Errors performs here