Versions Compared

Version Old Version 29 New Version Current
Changes made by

Christophe BETOULE

Gilles THOUENON

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

available at TransportPCE meetings
https://lf-opendaylight.atlassian.net/wiki/display/ODL/TransportPCE+meetings

2024-

...

General Information

...

12-19

Code Review

  • No merged change this week.

Changes transportpce under review on master branch:

  • “Handle modifications in existing RPCs and new RPCs”, “Create topo Context at Init for Alien & SBI”, “Add Tapi Abstracted Node to OR Topo” and “Add Func Test for Topology extension” pass the gate and are ready for merge after a clean-up.
  • Relation Chain of Smartoptics :
    • “Consistent cent. freq. width decimal precision” Corrects an issue where the nr of decimals for central frequency was 4 in ZtoA direction and 5 in AtoZ direction
    • “Implement service-format 'other'” : This update introduce a new service-format which ensures the mc interface is 8GHz wider than the nmc interface.
    • “Implement client create service frequency choice” : Implement the augmentations found in transportpce-service-spectrum-constraint@2023-09-07.yang. The opportunity for this change was discussed during the meeting and it revelency needs to be investigated.
    • “New packages simplifying picking service frequency” : simplify selecting an available frequency range from which a subset may be setup for a new service. It has been reviewed by Olivier and LGTH.
    • “Augment service-create adding frequency properties” : the yang file has be renamed from com-smartoptics-openroadm-service.yang  to transportpce-service-spectrum-constraint. This change is ready to be merged unless there are clarifications to be made on ranges of values ​​to be specified in the model.
    • “Check if SRG has available PPs before access” : If all PPs are used for any SRG, node validation will crash in getRdmSrgClient because it tries to access the first element of the empty available PP set, causing path computation failure even if there are other SRGs with available PPs. This fixes the issue by moving the existing check for empty available SRG PPs to before trying to access the first element. The change is ready for review and passes the gate.
    • “Ignore end node without available TPs in PCE” corrects a bug so that a node that has no available tps is effectively ignored. It is ready for review and passes the gate
    • “Set ServiceFeasibilityCheck to false for some rpcs” from Jonas has been rebased and passes the gate. The change has been reviewed by Olivier. If Christophe review is positive, this change could be merged.
  • “Add CEPlist to OTS NEP at init” : Add Cep list to Owned node edge points for Xponders at initialization corresponding to T0 configuration. This change allows completing the topology as required for the purpose of debugging the relation chain associated with the PCE link and node classes.
  • “Fix ROADM provisioning for 7.1 models ” : Bala has added his signoff so that the change passes the pre-commit, but asks not to merge the change since additional work is needed. Especially when a 2.2.1 ROADM is connected first and a 7.1 connected after, the neighbor is not recognized and the links between them are not created. Bala needs to update some codes in the OLM to implement for 7.1 span-loss retrieval.

Other items

  • Olivier briefly introduced the way topology extensions are managed

2024-11-14

General Information

  • Scandium SR1 has been released the 11th of November. We still need to update the release notes.

Code Review

...

  • A new relation chain pushed by Gilles to correct the TRNSPRTPCE-837 bug associated with tapi feature installation which disactivated SH and PCE features, has been merged on Scandium. The issue was the fact that we were loading transitive dependencies that are incompatible with other dependencies notably in GNPy consumer that uses jersey dependencies. In a first attempt, Gilles tried to close Gnpy consumer. Jersey core and client dependencies have been removed in a second change and replaced by odl-jersey2 dependency. In a third step, the same was applied to dmaap-client. In a 4th step, Gnpy consumer has been completely reworked (“Reimplement GnpyConsumer without Jersey”) where all jersey dependencies have been removed, which aligns with Robert strategy for ODL evolution. The related changes have been backported to master.
  • Jonas fixes and Joakim changes have been merged on master and backported on Sc branch.
  • The change provided by Fujitsu has been reviewed and merged.

Changes transportpce under review on master branch:

  • The change provided by Fujitsu has been reviewed and could be merged after a review that Christophe needs to do. 
    • “Migrate to Apache Peko” still fails.
    • “Upgrade lighty node version”. Some models were not correctly announced by lighty node. Lighty node has been updated to be in line with Roshan changes so that the configuration provided with the change for tests can be supported. “Enhancements for discovering OpenConfig XPDRs” has been adjusted to be in line with the new version of lighty node.
    • On the CI 2 changes have been proposed by the LFN. But they now fail.
    • “Add OSNR calculations for IPoWDM use case”, “Read optical operational-mode in temp-service-create” & “add common-id to path computation request” will need to be rebased. Bala considers they are ready to be merged if they pass the gate after being rebased. Proposed a rather long time ago, they need to be rebased.

2024-12-12

General Information :

  •  CA SR3 shall be submitted to vote during next TC meeting this evening.
  • Gilles started investigating issues experienced by Joakim and Olivier at TAPI feature installation / uninstallation. The issue appears locally but does not seem to appear on the gate (TAPI functional tests pass). At TAPI feature installation , the pce bundle is restarted by karaf. Because of the gnpy consumer, karaf does not succeed in restarting the bundle. This also implies as a result a failure in the service Handler. Gilles has probably found a workaround, but may need to investigate a little bit more to put this in place.

Code Review

Changes merged  since last meeting:

  • Changes stable/calcium branch, related to the backport of some changes from master branch to release Ca-SR3, including major bug fixes, and population of Operational mode in the topology

Changes transportpce under review on master branch:

  • Jonas and Joakim changes shall be merged in a short time.
  • The change provided by Fujitsu is almost ready to be merged. Olivier will review it to confirm.  
  • On the CI side, 2 changes have been proposed by the LFN. They are OK as Gilles’ comments have been addressed, and ready to be merged.

2024-12-05

General Information :

  • We still need to update the revision notes for Sc SR1.

Code Review

No changes merged during the week.

Changes transportpce under review on master branch:

  • “Adjust Xponder nrg/irg computation“ provides some adjustments handling Node Rule Group and Inter Rule Groups in Xponders
  • “Adjust ROADM IRG computation”: does the same for ROADMS
  • ”Add Cep List to OTS ”: refines the creation of CEP in CEP-list of Owned Node Edge Points, which is crucial to handle disaggregation of ROADM nodes required by the assumption we use in PCE TapiLink and TapiNode classes
  • The 3 changes mentioned above shall remain as WIP since a change on top of them will bring corrections to the way we handle tapi feature installation/uninstallation.
  • Joakim Relation chain: Frequency-slot container in service-create is triggered now when service is created with service-format = other. The class ValidFormat of change 113982 is checking the correct format of the service-create since it seems that yang-tools does not handle perfectly the when statements.
  • “Enhancement for discovering OpenConfig XPDRs”: This change creates a portMapping for OpenConfig Xponders. Christophe started reviewing it.

2024-11-28

General Information :

  • We still need to update the revision notes for Sc SR1.

Code Review

Changes merged  since last meeting:

  • “Handle modifications in existing RPCs and new RPCs”, “Create topo Context at Init for Alien & SBI”, “Add Tapi Abstracted Node to OR Topo” and “Add Func Test for Topology extension” have been merged.

Changes transportpce under review on master branch:

  • “Enhancements for discovering OpenConfig XPDRs”: Roshan pushed his work to get OpenConfig transponders in the portMapping (OCPortMapping) on behalf of NTT. This huge change corresponds to the backport of the work done on the private dev repository.
  • “Adjust ROADM IRG computation”: This WIP change is part of the relation chain dedicated to the corrections on Tapi Topology creation. It corrects Inter-Rule-Group computation for ROADM, to build as many IRGs as SRGs including 2 associated-node-rule-groups (1<->SRG,1<->DEG). The change includes adjustment to Junit tests.
  • “Add CEPlist to OTS NEP at init”: This change has been amended by a patchset that adds OTS Cep creation at init for PPs and Degrees, and modifies CEP name to differentiate from NEP names adding "CEP+" at the beginning of Cep Name.”
  • The debugging of Tapi link and node classes of the PCE is still ongoing and the corresponding relation chain has been updated (Add Junit Tests of Tapi Link & Node Classes, Add Tapi Topo File for test, Initial T-API 2.4 PCE link and Node Classes)
  • “Uninstall tapi feature at the end of functional tests” has been abandoned since a better workaround has been provided in a relation chain that is already merged.
  • “Set serviceFeasibilityCheck to false for some RPCs” is ready to be merged.
  • “Ignore end node without available TPs in PCE”: Joakim added this change to solve a bug in path computation that occurs when there are no available TPs. This change and “Check if SRG has available PPs before access” are ready to be merged
  • “Augment service-create adding frequency properties”: the yang file has been renamed from com-smartoptics-openroadm-service.yang  to transportpce-service-spectrum-constraint. However the change is still not ready to be merged since Joakim may add a when statement in the yang file, to trigger containers related to frequency and slot in the service-create. This is to avoid potential caveats he has identified.

2024-11-21

General Information

  • We still need to update the revision notes for Sc SR1.

Code Review

No merged change this week.

Changes transportpce under review on master branch:

  • “Handle modifications in existing RPCs and new RPCs”, “Create topo Context at Init for Alien & SBI”, “Add Tapi Abstracted Node to OR Topo” and “Add Func Test for Topology extension” pass the gate and are ready for merge after a clean-up.
  • Relation Chain of Smartoptics :
    • “Consistent cent. freq. width decimal precision” Corrects an issue where the nr of decimals for central frequency was 4 in ZtoA direction and 5 in AtoZ direction
    • “Implement service-format 'other'” : This update introduce a new service-format which ensures the mc interface is 8GHz wider than the nmc interface.
    • “Implement client create service frequency choice” : Implement the augmentations found in transportpce-service-spectrum-constraint@2023-09-07.yang. The opportunity for this change was discussed during the meeting and it revelency needs to be investigated.
    • “New packages simplifying picking service frequency” : simplify selecting an available frequency range from which a subset may be setup for a new service. It has been reviewed by Olivier and LGTH.
    • “Augment service-create adding frequency properties” : the yang file has be renamed from com-smartoptics-openroadm-service.yang  to transportpce-service-spectrum-constraint. This change is ready to be merged unless there are clarifications to be made on ranges of values ​​to be specified in the model.
    • “Check if SRG has available PPs before access” : If all PPs are used for any SRG, node validation will crash in getRdmSrgClient because it tries to access the first element of the empty available PP set, causing path computation failure even if there are other SRGs with available PPs. This fixes the issue by moving the existing check for empty available SRG PPs to before trying to access the first element. The change is ready for review and passes the gate.
    • “Ignore end node without available TPs in PCE” corrects a bug so that a node that has no available tps is effectively ignored. It is ready for review and passes the gate
    • “Set ServiceFeasibilityCheck to false for some rpcs” from Jonas has been rebased and passes the gate. The change has been reviewed by Olivier. If Christophe review is positive, this change could be merged.
  • “Add CEPlist to OTS NEP at init” : Add Cep list to Owned node edge points for Xponders at initialization corresponding to T0 configuration. This change allows completing the topology as required for the purpose of debugging the relation chain associated with the PCE link and node classes.
  • “Fix ROADM provisioning for 7.1 models ” : Bala has added his signoff so that the change passes the pre-commit, but asks not to merge the change since additional work is needed. Especially when a 2.2.1 ROADM is connected first and a 7.1 connected after, the neighbor is not recognized and the links between them are not created. Bala needs to update some codes in the OLM to implement for 7.1 span-loss retrieval.

Other items

  • Olivier briefly introduced the way topology extensions are managed

2024-11-14

General Information

  • Scandium SR1 has been released the 11th of November. We still need to update the release notes.

Code Review

3 changes merged during the week : “Adjust tox ini tests sequencing”, “Yang file to augment OR Topology”, and “networkutils RPCs adjusted for topo extension”. This corresponds to the bottom relation chain on TAPI work.

Changes transportpce under review on master branch:

  • “Handle modifications in existing RPCs and new RPCs” passes the gate and is ready for merge.
  • “Add Tapi Abstracted Node to OR Topo” : still does not pass the gate but is probably due to an issue on the gate (221 tests).
  • “Add Func Test for Topology extension” : still does not pass the gate but is probably due to an issue on the gate (221 tests).
  • “Uninstall tapi feature at the end of functional tests” is a standalone change that could be merged on other branches than master (on master branch, the code it is already integrated in “Add Tapi Abstracted Node to OR Top”). The purpose of the change is to uninstall the tapi feature at the end of each tapi functional test.
  • “Migrate to Apache Pekko” : allows to use Pekko in place of Akka. This change does not pass the gate. Robert has been added as a reviewer to help understanding us why.
  • Relation Chain of Smartoptics : The changes at the bottom of the stack have been merged. Joakim shall rebase next changes on the master branch.
  • “Augment service-create adding frequency properties” : the yang file shall be renamed from com-smartoptics-openroadm-service.yang  to something like transportpce-service-spectrum-constraint.yang : including the name of an OEM in the title of the yang file suggests that this file is dedicated to specific equipment, which is not the case. Also having openroadm in the title could bring confusion as this is an extension of openroadm models but is not part of them.
  • “Set ServiceFeasibilityCheck to false for some rpcs” from Jonas shall be rebased to check that it passes the gate.
  • “Fix ROADM provisioning for 7.1 models ” : Bala shall add his signoff so that the change passes the pre-commit.

2024-10-24

General Information :

  • Scandium still not released. Deadline is today. Some core projects have been released. Tpce is the only one not released yet.

Code Review

No Change merged  this week.

Changes transportpce under review on master branch:

  • Joakim provided some modifications to its relation chain:
    • “Augment service-create adding frequency properties”: Joakim updated this change changing slot-width to GHz rather than Integer.
    • “New package simplifying picking service frequency”: does not pass the gate and probably needs to be rechecked.
    • “Implement client create service frequency choice”: One Graphtest is failing (the test shall probably be adjusted.
  • “Yang file to augment OR topology”;  “networkutils RPCs adjusted for topo extension”; “Handle modifications in existing RPCs and new RPCs”  and “Create topo Context at Init for Alien & SBI” have been set as ready for review
  • “Add Tapi Abstracted Node to OR Topo”: still does not pass the gate but is probably due to an issue on the gate (121 test + tapi tests)
  • “Add Func Test for Topology extension”: still does not pass the gate but is probably due to an issue on the gate (121 test + tapi tests)
  • “Correct bugs handling spectrum constraint”: Answer provided to Jonas Comment.
  • “Fix stpectrum assignment computation”: turned back as WIP as still some work needs to be done.
  • “Set ServiceFeasibilityCheck to false for some RPCs”: needs to be reviewed by Christophe.

Other

  • UTD ask if the bug associated with the selection of ports through service-create, when specifying the port in the input has been solved. The answer is no. In some case it still doesn’t work.

  • Linqi exposed the issues he is experiencing connecting to nodes in the labs. Bala suggested to use K in place of Ar.

  • UTD is asking for the purpose of OFC 2025 demonstration what would be the best option to handle post R7.1 ROADMs (Probably R 12.1 but to be confirmed). The 7.1 ROADMS have not been tested with TransportPCE

2024-10-17

General Information :

  • Scandium SR1 shall be released next week.

Code Review

No Change merged  this week.

Changes transportpce under review on master branch:

  • Joakim provided several changes in a relation chain:
    • “Augment service-create adding frequency properties”: This commit augments the OpenROADM create-service API with frequency related properties. The intent is to provide a way for the client to influence/choose the frequency range when setting up a service. The client could specify a range of frequency, or even a frequency slot to be used.
    • “New package simplifying picking service frequency”: provides all the classes and interfaces needed for the implementation of the new attributes introduced through the augmentation of the service-create
    • “Implement client create service frequency choice”: Implementation in PostAlgoValidator of the constraint imposed through the augmentation of service-create.
  • “Set service feasibility check to false for other RPCs” provided by Jonas, solves a bug in service handling that exits after path computation was completed because service feasibility check variable is not correctly handled.
  • “Fix spectrum assignment computation”: Gilles asked if a Junit test could be provided for this change.

2024-10-10

General Information :

  • Release status: No specific information. Titanium planned for March 25th

  • TSC Meeting schedules: went from 1 meeting per week to 2 meetings /month

Code Review

Changes merged  since last meeting:

  • “fix revision in openconfig model” (stable/calcium branch). This change will need to be backported on stable/scandium and master branches

Changes transportpce under review on master branch:

  • “Migrate to Apache Pekko” is not ready to be merged because it depends on the upstream controller project.
  • “Correct bugs handling spectrum constraint”: Olivier provided this change to solve an issue experienced by NTT while using controller-customization module to restrict the wavelength used through a customer profile.
  • “Add Tapi Abstracted Node to OR Topo”:  allows creating at controller initialization a TAPI-EXT node that corresponds to an abstraction of the T-API topology that we will retrieve from the South Bound interface. This at each level of the OR topology.
  • “Add Func Test for Topology extension”: Provide some tests related to the relation chain associated with the topology extension.

2024-10-03

General Information :

  • Release status: ODL Scandium GA and Ca-SR2 distributions have been released. Only the release notes need to be provided.

  • Until last week , TSC meeting were every weeks, now they will be every 2 weeks (Most of important points discussed on Slack).

Code Review

Changes merged  during the week:

  • “Bump Project version to 9.3.0-SNAPSHOT”. (transportpce)
  • “Bump Project version to 20.3.0-SNAPSHOT”. (transportpce models)

Changes transportpce under review on master branch:

  • “fix revision naming in openconfig models”. Christophe made a correction on the revision of openconfig-bgp-errors. The change was merged during the meeting.
  • “Link node id to node name conversion in TAPI” & “Fix grid spectrum computation (reversed logic)” can be merged.
  • “Populate OM in portMapping and Topo” and “Fix a few bugs processing Topo” could be merged after they have been rebased.

Other

  • UTD has some interests in leveraging HoneyNode/LightyNode as simulators. From a pure maintenance point of view, Gilles recommends using LightyNode rather than HoneyNode. Lighty is developed by Pantheon: they are very active in ODL which improves the probability to get support if new issues come out. LightyNode will however not support RESTCONF API to modify some parameters directly in the node. This means it won’t support this kind of change in the configuration performed through Postman-like operations. We tried to include a RESTCONF connector in LightyNode, and succeeded, but it affects the performance of LightyNode. Thus, we decided not to activate it. The RPCs used to modify some parameters in the node can be invoked relying on NETCONF, so that this mechanism is supported on LightyNode.

2024-09-26

General Information :

  • Release status:

    • Scandium and Ca SR2 should be under TSC approval soon.
    • Gilles released artifacts and managed the integration of tpce for both Scandium and Calcium
    • The Swagger issue shall have been solved. First issue raised through JIRA ticket has been solved, but a new issue appeared. Sanhook reproduced the issue we have. He made yesterday a patch in Netconf to limit the number of search to 100, and this patch works. It will be corrected in Ca with Netconf 7.0.11, in Sc with Netconf 8.0.3.

Code Review

Changes merged  during the week:

  • All changes related with project version bump for both Ca and Sc and both Tpce and tpce/models have been merged. This is mainly concerning NETCONF dependency . This update affects the way we are using Netconf since netconf nodes are now embedded in a netconf-node-topology:Netconf-node container. This affects the code using Netconf-connector, some tests and the postman collections we are using.
  • Gilles improved the way we used test libraries in “Refactor test utils lib to improve the Reg search” which optimizes the time required for the tests. The process to connect to Netconf nodes is improved with both types of simulators (HoneyNode/LightyNode)
  • “Update Netconf node mount settings in funct tests”: Gilles changed the number of connections attempts from 0 to 5. He hopes this will help solving the issue we currently experience on the gate.

Changes transportpce under review on master branch:

  • “Handle modifications in existing RPCs and new RPCs” passes the gate and is ready for merge.
  • “Add Tapi Abstracted Node to OR Topo” : still does not pass the gate but is probably due to an issue on the gate (221 tests).
  • “Add Func Test for Topology extension” : still does not pass the gate but is probably due to an issue on the gate (221 tests).
  • “Uninstall tapi feature at the end of functional tests” is a standalone change that could be merged on other branches than master (on master branch, the code it is already integrated in “Add Tapi Abstracted Node to OR Top”). The purpose of the change is to uninstall the tapi feature at the end of each tapi functional test.
  • “Migrate to Apache Pekko” : allows to use Pekko in place of Akka. This change does not pass the gate. Robert has been added as a reviewer to help understanding us why.
  • Relation Chain of Smartoptics : The changes at the bottom of the stack have been merged. Joakim shall rebase next changes on the master branch.
  • “Augment service-create adding frequency properties” : the yang file shall be renamed from com-smartoptics-openroadm-service.yang  to something like transportpce-service-spectrum-constraint.yang : including the name of an OEM in the title of the yang file suggests that this file is dedicated to specific equipment, which is not the case. Also having openroadm in the title could bring confusion as this is an extension of openroadm models but is not part of them.
  • “Set ServiceFeasibilityCheck to false for some rpcs” from Jonas shall be rebased to check that it passes the gate.
  • “Fix ROADM provisioning for 7.1 models ” : Bala shall add his signoff so that the change passes the pre-commitJoakim pushed a new change fixing the way we attribute frequency slots,  in Fix and Flexgrid approach “Fix grid spectrum computation”. This is correcting a wrong implementation due to an error in a condition statement.
  • Olivier pushed a new relation chain dedicated to the augmentation of the OpenROADM topology to extend its scope and being able to include some openConfig devices , and model an abstraction of the TAPI topology that will be retrieved from the SBI as a single node.
  • “Yang file to augment OR topology” provides a new yang file that includes all augmentations allowing to take into account specific parameters of OpenConfig NEs that do not have any equivalent attributes in the OR topology, and all attributes allowing a better identification of Nodes and link (node-model, link-class…) in the scope of planned extensions.
  • “networkutils RPCs adjusted for topo extension”, is refining the input of some of the RPCs used to create links (adding parameters required in the scope of the extension planned) and defines a new RPC that allows creating interdomain links, for use case where services might span across several domains (OpenROADM/T-API) .
  • “Handle modifications in existing RPCs and new RPCs” provides adjustment in the code that allow taking into account the extensions that are provided in the different augmentations of the 2 previous changes.

2024-09-19

General Information

  • Scandium is not released yet because of some regressions detected in the NETCONF project. So we are waiting for the availability of the latest NETCONF dependency. Robert published this afternoon netconf-8.0.2 which corrects the bug we reported for the swagger issue.
  • Ca-SR2 release is also pending for the same reason.

Code Review

No change merged during the week

...

  • Scandium shall be released next week. Gilles released tpce artifacts. But some regressions were detected in the NETCONF project. So we will need to take into account the new NETCONF version.
  • Gilles also started the release process for Ca-SR2 but NETCONF project has the same impact.
  • Gilles raised a Jira Ticket NETCONF-1386 to highlight the fact that the swagger interface is again not working.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Scandium shall be officially released in 2 weeks. Tpce Scandium migration is almost done.
  • CA-SR2 is almost 1 month late. Gilles backported some changes on the stable/calcium branch. He is experiencing a lot of CI issues, mostly with maven-verify job. The root cause could be on the aaa project. It seems that, among other things, passwordService dependency is missing for org.opendayligth.aaa.datastore.h2.H2Store bundle.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • ODL's TSC has just been renewed: Technical Steering Committee (TSC) - OpenDaylight - Confluence (atlassian.net)
  • Code Freeze for Scandium happened 2 weeks ago. Master branch shall be migrated to Titanium. The ODL Scandium release is planned on the 19th of September.
  • Our ODL JIRA and Wiki have been migrated to Altassian Cloud. For Jira a double authentication is needed. Some convenient features have been lost (link with Gerrit change associated with the Jira Ticket not yet effective).
  • LFN is thinking moving the tox-verify jobs from Jenkins to Github Action

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • changes related to the IPoWDM use case and just upadated by Bala. They are now in review:
    • “Add common-id to path-computation”: OK for merging, but before add a Jira ref
    • “Read optical-operational-mode in temp-service-create” allows retrieving the op-modes provided in the requesting-interface-properties container of temp-service-create, which is needed for path computation with external pluggable. It currently fails at the service handler level. JUnit tests of servicehandler still need to be updated with code modification done.
    • “Add OSNR calculations for IPoWDM use case” provides impairment aware path computation according to the operational modes provided in the temp-service-create in IPoWDM use case. Olivier shall review this change.
  • One change from Ivan Hraško on migration from akka to Apache peko:
    • “Migrate to Apache Pekko”: we need to wait for change111858 on controller project to be merged before merging it.
  • changes on TAPI module proposed by Smartopics:
    • “Frequency rounding error in GridUtils” is a new bug detected by smartoptics. At first sight, we are ok with this fix
    • "Error due to empty list of XPDR in TAPI", "Error due to duplicate roadm node id key in TAPI", "Error in TAPI creating frequency ranges" are other bugs detected in TAPI. OK with that, but they are above the following change that still need a review...
    • "New Tapi package dealing with frequency BitSets": proposes a new TAPI package dealing the frequencyBitSets. After exchange between Joakim and Olivier, this package has been refactored by Joakim… Need to be reviewed again by Olivier (and others)
  • “Upgrade lightynode to Ca-SR1” : Gilles prefers to merge this change after major issues related to scandium migration have been fixed in order to have a stable simulator version for tests
  • “Bump Upstream dependencies for 2024.09 Scandium”: Gilles started the migration of master branch to scandium. The compilation with JUnit tests is OK, but lots of functional tests are failing for two main reasons:
    • the return of the request when the requested data in the datastore does not exist changed
    • the netconf device notification registration is no longer effective with lightynode simulator (it works with honeynode, but honeynode is no longer used for TPCE functional tests on the CI)
    • Gilles reported these issues towards upstream projects. Waiting for their feedbacks...

2024-07-25

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Migration to Scandium shall start soon. Scandium will require Java 21 and Maven 3.9.5 for build and run.

  • The gate is in bad shape!

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • “Add common-id to the path computation request” & “read optical-operational mode in temp-service-create” are 2 changes pushed by Bala to handle the IPoWDM use case.
  • Olivier has pushed a number of Change related to T-API, mainly for backup, all of them being in WIP state. The changes pushed on stable/Ca will need to be pushed on Master for simplification of the integration of these changes.

Other

  • Discussion about IPoWDM Use case:

    • The user can push more than one mode in the temp-service-create. A priority is associated to them. Post algo validator is responsible for evaluating the impairment on the path and compare them with the specifications of the transponder, determined by the operational-mode. For tunnel, at that time, _and because the code was written before we model the IPoWDM use case in OpenROADM_ PostAlgoValidator does not compare OSNR resulting from the degradation on the OLS with the performance of end-terminals, since we had no way to know those.
    • Now that we use models allowing the implementation of IPoWDM Use Case, the code of the PostAlgoValidator for tunnels shall be modified to do exactly what is done in a regular case. The only difference is that the performances of the end-terminals are not extrapolated from the last node of the path (because in the case of a tunnel, this is a SRG Add/drop, and not a transponder) but from the operational-modes that have been provided in the container “requesting-interface-properties” of the temp-service-request. But the calculation and the way performance are retrieved in the catalog from the operational-mode do not change.

...

  • ODL scandium release (planned for September) is underway in upstream projects: wil require Java-21 for build and runtime, and Maven-3.9.5+

Code Review

Changes transportpce under review:

...

  • Ca-SR1: has been approved by the TSC so that it shall be released in a short time

Code Review

Changes transportpce under review:

  • “Address Comments on Change 111419”: the title shall be independent from any reference to Gerrit.
  • “Deleting openroadm after controller restart” Olivier made a review on Jonas’ change.
  • “Bump CI scripts to Ubuntu 20.04”. Gilles pushed this change to repair the gate.

Other

  • Christophe has identified that the issue with lighty node comes from the fact that a bug in Yang-Tools for models that have complex interactions, solved in version 13.0.4 of Yang-Tools,  available in Ca SR1, has still not been integrated in Lighty. Christophe would like to push OpenConfig R2.0 models on transportpce. No objection.

...

  • Ca-SR1: is still under TSC validation

  • K-SR3 has been released.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Ca-SR1: shall be under TSC validation, but a new issue has been identified in the NETCONF project. We could need to respin it...

  • K-SR3: Gilles released TPCE artifacts today morning. The release candidate shall be under TSC validation today.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Ca-SR1 shall be under TSC validation, but an issue has been identified (One dependency update on the AAA project was forgotten). Ca SR1 release process need to be respined now.

  • K-SR3 should be ready by 2 weeks.

Code Review

No change merged during last week.

...

  • Ca-SR1 is under progress: Gilles backported from master all changes of interest for the release. An issue detected by our functional test has been solved thanks to Pantheon regarding Lighty.io, but we still experience lots of issues with the gate, due to several cumulative issues on the infrastructure. Need to relaunch everything...

  • K-SR3 should start very soon.

  • Scandium is planned for September.

Code Review

Changes transportpce under review:

...

  • Ca-SR1: tpce artifact will need to be published next week as soon as the Netconf dependency is available.

  • K-SR3 should have been released last week, so it will come soon.

  • Scandium is planned for September.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

No Meeting. Public holiday.

2024-05-02

Code Review

Changes merged  since last meeting on transportpce:

...

  • LFN DTF summit will be hold on the 2nd and 3rd of May in San Jose. Deadline for registration is on the 12Th of May.

  • We are using Teams for tpce meetings, and the LFN recommends to use their Zoom tool. However neither Orange nor AT&T company authorize to use zoom tool...

  • Gilles published last week TPCE artifacts for Ca. For what concerns tpce, everything has been done. The distribution shall be released next week after the TSC as approved it.

  • A change in Netconf is currently under review to solve our OpenAPI issue.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Changes corresponding to the branch managements, bump of project versions associated to Ca and the evolution of the different branches.
  • Note : We have diverged so much from K in Ca that only a few changes will be backported to K for SR3 release.
  • Guillaume changes associated to the refactoring of tapi module as well as the correction of 2 bugs that were reintroduced through wrong multiple merge-conflicts management.
  • “Use Map in TAPI topology ConvertORToTapiTopology” is a code optimization proposed by Guillaume to reduce the cyclomatic complexity
  • “Update tpce release note for Calcium” has been merged, but we forgot to mention the Rollback -process refactoring of SmartOptics and the AT&T work around IPoWDM use case. Will be updated.

Other

  • sprint 34 is cloed in session, and the next one launched.

...

  • Ca GA is still under progress and should be available very soon now. TPCE  is more or less the only project that needs to be released now.

  • Transportpce has been demonstrated last week during the OFC event. Bala provided some feedbacks. A lot of people followed the event this year and there was a lot of visitors on OpenROADM booth

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • LFN migrated its servers from US to Europe: as a result, JIRA, Gerrit and CI/CD experienced some issues that have been rather solved.

  • Ca should have been released on the 14Th but it is still under preparation.

Code Review

Changes merged  since last meeting on transportpce-models and transportpce:

...

  • Ca release is on track. It is targeted the 21st of March. The TPCE master branch migration to Ca is in good shape.

  • Registration and topic submission period is still open for the next DTF (Developer and Testing Forum)  which will happen in San Jose the 2nd and 3rd of May.

Code Review

Changes merged  since last meeting on transportpce-models:

...

  • mainly the relation chain related to the Ca migration
    • “Make lighty non-voting in CI”: Because the migration of lighty core is still under process, we need to disactivate lighty voting, temporarily until lighty is migrated to Ca. The lighty build issue (availability of RpcService) has been fixed during the week. As soon as Lighty is ready for Ca, we are able to revert this change to reactivate TPCE lighty build.
    • “Bump upstream dependencies to Ca” is now ready to be merged. The merge of Smartopics' changes has implied to rebase this change which took times. 
    • “Fix Renderer Junit tests exceptions": during the execution of the renderer Junit tests, lots of exceptions were raised. Gilles repaired and adapted the Junit tests so that they can run without any exception. This also allowed to rebase Jonas change “Only verify PreFEC BER if end node is Xponder” which now passes the gate.
    • Guillaume is working on different changes to apply code style rules : “Refactor common CrossConnectImpl”, “Fix inventory listener code indentation” & “clean up nbiNotifications after Ca Bump”
  • “Refactor Tapi 2.4 final touch” and “…. final touch2 ” shall be squashed and then will be ready to merge.

Other

  • An update of upstream dependencies for Ca GA, is currently ongoing. It is needed for the migration to Ca.

  • Everyone shall try to update his Jira Ticket so that we could close the Sprint after the migration to Ca has been accomplished (Please try to update before next week meeting).

  • Nathan mentions that they still experience some issue with Netconf session on devices from TransportPCE, when at the same time other sessions are in place to catch PMs on devices; whereas the device is supposed to support multiple (up to 18) sessions at the same time.

...

  • Topic submission period is still open for the next DTF (Developer and Testing Forum)  which will happen in San Jose in April.

  • Ca preparation is ongoing with the target of 21st of March

Code Review

Changes merged  since last meeting on transportpce-models:

...

  • Topic submission period is open for the next DTF (Developer and Testing Forum)  which will happen in San Jose in April.

Code Review

Changes merged  since last meeting on transportpce-models:

...

  • The annual LFN 2024 mentorship program has been launched.  Selection progress is already started. The deadline for submission is the 17th of March. This program allows mentoring students that are willing to contribute to a project.

Code Review

Changes merged  since last meeting

...

  • 4 changes associated with TAPI refactoring are still in review status. 3 of them could be merged. “Outsource TAPI test constants from test utils” may not be merged according to the comments that were made.
  • “Fix OLM rollback” and “Allow 0 dB spanloss in power management” could be merged. For other SmartOptics changes, we may wait since they do not pass the gate.
  • “Fix persistence when karaf is restarted” : Guillaume had a look at it and asked for an adaptation. He suggested to adjust the script used at initialization.
  • Smartoptics provided 2 changes to correct RollBack function : “New package dealing with device Rollback” & “Refactoring Rollback when service create fails”. Bala did not have time  to review it.
  • SmartOptics proposed an additional relation chain including  “Determine preferred node/port from PCRI” and “Allow the client to specify ROADM service SRG port” which address Bala’s bug TRNSPRTPCE-176

Other

  • Christophe and Gilles succeeded in integrating OpenConfig Models and the xml configurations in Lighty Node. They still have an issue to build the right xsl transform to expose the configuration in the Operational DataStore.
  • Gilles confirms that we can change in OpenROADM MSA latest models the import of of iana-safi to iana-routing-types version 2022-08-19 which is the latest.

...

  • Next DTF Development and testing Forum will be hold in San Jose, collocated with ONE summit the 2nd and 3rd of May

Code Review

Changes merged  since last meeting

...

  • ODL distribution for K-SR2 is released. Release notes have been updated.

  • Gilles started the migration of master branch to Ca (targeted mid-March) which seems to have important side-effects on TransportPCE current implementation. Hope it will not be too much difficult to adapt...

Code Review

Changes merged  since last meeting

...

  • Potassium SR2 has just been approved by the TSC and the ODL distribution shall be released soon. For TransportPCE, the last changes that were pending (release note update in docs project) have been merged by Guillaume.

  • Gilles will probably start the migration of Master branches to Ca next week.

  • Robert informed the community about a migration to Java 21st planned in Ca SR1, and imposed in Scandium.

Code Review

Changes merged  since last meeting

...

  • Gilles released TransportPCE artifacts for K-SR2 + prepare its integration inside ODL distribtuion + prepare the release note on docs project

Code Review

Changes merged  since last meeting

...

  • Olivier is working on correcting and completing the OpenConfig device configuration for the lightynode simulator, making it closer to what we observe with equipment in the labs.

2024-01-18

Code Review

No change merged  since last meeting

...

  • Sprint 34 was initiated. All non-closed issues of previous sprint have been included. An additional issue #774 was introduced : Create an OpenConfig configuration file. Some JIRA ticket describing OpenConfig models to be introduced in tpce models need also to be created.

  • Christophe made a small project to illustrate the bug we have in lightynode for openroadm-device 7.1 models (handling when statement). He reported the issue on the odl-kernel list. The Issue is identified in the yangtools project, but it seems difficult to solve it, and no solution will be provided in a short time. 2 workarounds have been proposed.

  • Bala is trying to fix the way we are building A and Z end containers in service-create and temp-service-create so that he can retrieve the operational mode supported by external pluggables to address IPoWDM case.

  • He also started to implement the power control RPC to address IPoWDM use case.

  • Bug: When we specify the port to use in the service-create (for SRGs ending an optical tunnel), tpce is currently picking the port based on first port available, not considering the port specified in the service-create. Gilles started to work on this bug but did not have the time to work on any use case. He asked Bala to create a JIRA ticket to better understand the associated use case.

2024-01-11

Code Review

changes merged  since last meeting:

...