...
available at TransportPCE meetings
https://wiki.opendaylight.org/display/ODL/TransportPCE+meetings
2024-02-29
General information
Topic submission period is open for the next DTF (Developer and Testing Forum) which will happen in San Jose in April.
Code Review
Changes merged since last meeting on transportpce-models:
- OpenRoadm 13.1 models and the set of OpenConfig models have been merged.
Changes merged since last meeting on transportpce:
- “Add Customer name to pathComputationRequestInput“
- Guillaume changes on Tapi refactoring
- Jonas changes were merged (“Allow 0 dB spanloss in power management” and “Fix persistence when karaf is restarted”).
- “Determine preferred node/port from PCRI“, “New Package dealing with Rollback process” and “Refactoring rollback when service create fails”. Gilles hopes this will not have too many side effects on his change related to the migration to Ca since this is really complex. "Bumb upstream dependencies to Ca" is now in merge conflict state...
Changes transportpce under review:
- “Refactor PCE operator constraint “ has been proposed by Guillaume to optimize for loops.
- “Address yang name change for transportpce-pce “
- “Add a tox profile to install lightynode“ , “Switch all func tests to lightynode” and “ Complement sims configuration files” have been proposed by Christophe in order to migrate the CI/CD chain towards Lighty.io. => ready to be merged.
- “Refacto to Tapi2.4 Final touch” correspond to latest work associated with the migration to Tapi 2.4 , introducing spectral information in Neps. This change is not for review and has been set as WIP. It has been pushed for backup.
- “Only verify PreFec BER if end node is Xponder” currently fails. It will need to be rebased on Gilles's change on the migration because most of JUnit tests have been redone.
2024-02-22
General information
- The annual LFN 2024 mentorship program has been launched. Selection progress is already started. The deadline for submission is the 17th of March. This program allows mentoring students that are willing to contribute to a project.
Code Review
Changes merged since last meeting
- “Fix warning message when service creation fails” & “Fix ConvertORToTapiTopology Upper/Lower Freq bug”
Changes transportpce-models under review:
- Change associated OpenROADM device13.1 models and OpenConfig models could be merged
Changes transportpce under review:
- 4 changes associated with TAPI refactoring are still in review status. 3 of them could be merged. “Outsource TAPI test constants from test utils” may not be merged according to the comments that were made.
- “Fix OLM rollback” and “Allow 0 dB spanloss in power management” could be merged. For other SmartOptics changes, we may wait since they do not pass the gate.
- “Fix persistence when karaf is restarted” : Guillaume had a look at it and asked for an adaptation. He suggested to adjust the script used at initialization.
- Smartoptics provided 2 changes to correct RollBack function : “New package dealing with device Rollback” & “Refactoring Rollback when service create fails”. Bala did not have time to review it.
- SmartOptics proposed an additional relation chain including “Determine preferred node/port from PCRI” and “Allow the client to specify ROADM service SRG port” which address Bala’s bug TRNSPRTPCE-176
Other
- Christophe and Gilles succeeded in integrating OpenConfig Models and the xml configurations in Lighty Node. They still have an issue to build the right xsl transform to expose the configuration in the Operational DataStore.
- Gilles confirms that we can change in OpenROADM MSA latest models the import of of iana-safi to iana-routing-types version 2022-08-19 which is the latest.
2024-02-15
General information
- Next DTF Development and testing Forum will be hold in San Jose, collocated with ONE summit the 2nd and 3rd of May
Code Review
Changes merged since last meeting
...
- Smartoptics provided 2 changes to correct RollBack function : “New package dealing with device Rollback” & “Refactoring Rollback when service create fails”. Bala has been asked to review. The new functionality may be easier to test on devices than simulator. Gilles confirms that we can wait before merging it. In this change, multiple interfaces/classes were proposed to handle the rollback process. It is not that easy to figure out whether the new rewritten callback function will work, and the best option to test these changes is to test them on real equipment.
- “Fix OLM rollback” could be merged now. Not really dependent on the previous relation chain
- “False warning message when service creation fails” could be merged.
- “Only verify PreFEC BER if end node is Xponder” pushed by Jonas avoids reading PreFEC BER from end nodes when creating a ROADM-to-ROADM. Need to be check because one Junit test fails... Issue on the gate?
- “Add SpectrumFillingRule check in postAlgoValidator” : Olivier shall cleanup the Junit test before we merge it.
- Gilles initiated the migration to Ca with “Bump upstream dependencies to Ca”.
- “Add a Tox profile to install lightynode”, “Switch all func tests to lightynode”, “Upgrade LightyNode sim version” are still under review.
- “complement sims configuration files” passed the gate but seems to fail right now with the same issue that we experience with some other changes. Christophe continues debugging the OpenConfig xml configuration files. He experiences some issues with some augmentations, especially for components, and more specifically psu.
2024-02-08
General information
ODL distribution for K-SR2 is released. Release notes have been updated.
Gilles started the migration of master branch to Ca (targeted mid-March) which seems to have important side-effects on TransportPCE current implementation. Hope it will not be too much difficult to adapt...
Code Review
Changes merged since last meeting
...
- Guillaume has initiated a refactoring activity on TAPI code:
“Refactor Tapi Connectivity Utils” which simplifies the code style has been reviewed by Gilles,
“RefactorTapi ConvertORTopoToTapiTopo” has been reviewed by Gilles,
“RefactorTapi ConvertORToTapiTopology” : Gilles has reviewed it, Olivier started reviewing it but has not finished,
“Outsource TAPI test constants from test utils” has been reviewed by Gilles who provided some comments,
“Refactor Tapi ConvertORTopoToTapiTopo junit” & “Refactoring some Tapi Junit tests code ” have been reviewed by Gilles and merged in session
- Smartoptics provided 2 changes to correct RollBack function: “New package dealing with device Rollback” & “Refactoring Rollback when service create fails”. Bala has been asked to review. The new functionality may be easier to test on devices than simulator.
- New changes from Olivier related to the wavelength selection issue raised by NTT: “Add Customer name to path Computation”, and “Add SpectrumFillingRule check in postAlgoValidator” are 2 changes to handle a service creation according to a specific wavelength. As wavelength can not be provided as a constraint in service-create, we propose to leverage the spectrum-filling feature of Controller-behaviour-settings which was initially proposed to partition the spectrum across customers. Thus the wavelength constraint can be expressed as a specific customer profile (using customer-name in service-create) for which we dedicate a specific spectrum as specified in spectrum-filling-rules.
- Functional tests migration to lightynode:
- “Add a Tox profile to install lightynode”: Gilles pushed this change to allow installing lightynode according to any version (specific release or specific snapshot binaries)
- “Switch all func tests to lightynode”: Christophe's change allows to switch from Honeynode to Lighty for all the tests (1.2.1, 2.2.1, and 7.1). In tox.ini , it allows adopting lightynode sims for remaining 7.1, hybrid and with_docker tests. It also adapts tests using netconf connector instead of restconf one as soon as Lightynode does not support restconf api
- “Upgrade LightyNode sim version” upgrades Lightynode version to manage notifications for 1.2.1 and 7.1.0. Now integrated inside the previous one. Will be abandonned.
- “Complement sims configuration files” is complementing configuration files for 7.1 configuration (pm description and pm list)
2024-02-01
General information
Potassium SR2 has just been approved by the TSC and the ODL distribution shall be released soon. For TransportPCE, the last changes that were pending (release note update in docs project) have been merged by Guillaume.
Gilles will probably start the migration of Master branches to Ca next week.
Robert informed the community about a migration to Java 21st planned in Ca SR1, and imposed in Scandium.
Code Review
Changes merged since last meeting
...
- Olivier has provided a draft of the OpenConfig device configuration for Lighty, which consistency shall be tested.
- reminder: url to use to have swagger is http://<server>:8181/openapi/explorer/index.html
2024-01-25
General information
- Gilles released TransportPCE artifacts for K-SR2 + prepare its integration inside ODL distribtuion + prepare the release note on docs project
Code Review
Changes merged since last meeting
...
- Olivier is working on correcting and completing the OpenConfig device configuration for the lightynode simulator, making it closer to what we observe with equipment in the labs.
2024-01-18
Code Review
No change merged since last meeting
...
Sprint 34 was initiated. All non-closed issues of previous sprint have been included. An additional issue #774 was introduced : Create an OpenConfig configuration file. Some JIRA ticket describing OpenConfig models to be introduced in tpce models need also to be created.
Christophe made a small project to illustrate the bug we have in lightynode for openroadm-device 7.1 models (handling when statement). He reported the issue on the odl-kernel list. The Issue is identified in the yangtools project, but it seems difficult to solve it, and no solution will be provided in a short time. 2 workarounds have been proposed.
Bala is trying to fix the way we are building A and Z end containers in service-create and temp-service-create so that he can retrieve the operational mode supported by external pluggables to address IPoWDM case.
He also started to implement the power control RPC to address IPoWDM use case.
Bug: When we specify the port to use in the service-create (for SRGs ending an optical tunnel), tpce is currently picking the port based on first port available, not considering the port specified in the service-create. Gilles started to work on this bug but did not have the time to work on any use case. He asked Bala to create a JIRA ticket to better understand the associated use case.
2024-01-11
Code Review
changes merged since last meeting:
...